Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

animation div sticky correction #6130

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+1 −2
Open

animation div sticky correction #6130

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9d62e6b
animation div sticky correction
balagowda Dec 23, 2024
5c84291
removed comments from the style
balagowda Dec 25, 2024
1bbfd03
Merge branch 'master' into animation
balagowda Dec 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/sections/General/Navigation/navigation.style.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import styled from "styled-components";

const NavigationWrap = styled.header`
position: sticky;
// position: sticky;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove it if not needed, don't keep it as comment

width: 100vw;
z-index: 9999;
top: 0;
Expand Down
1 change: 1 addition & 0 deletions src/sections/Meshery/How-meshery-works/howitworks.style.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ h2 {
}
.diagram {
margin-bottom:150px;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why extra margin?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sudhanshutech Left div will go to the end of the parent div, compared to the right div, which looks bad. So, I added a margin there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-12-25 at 11 44 14 AM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can see the left div reaching the end.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this is after adding margin
Screenshot 2024-12-25 at 11 48 31 AM

width: 591px;
max-width: 100%;
position: sticky;
Expand Down
2 changes: 1 addition & 1 deletion src/sections/app.style.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ body {
transition-timing-function: cubic-bezier(0.2, 0.8, 0.2, 1);
font-family: "Qanelas Soft", "Open Sans", sans-serif;
overflow-x: hidden !important;
// overflow-x: hidden !important;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here remove it

font-weight: 400 !important;
margin: 0;
padding: 0;
Expand Down
Loading