-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
animation div sticky correction #6130
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: balagowda <[email protected]>
🚀 Preview for commit 9d62e6b at: https://67694a5916d269264ab11c3b--layer5.netlify.app |
@@ -1,7 +1,7 @@ | |||
import styled from "styled-components"; | |||
|
|||
const NavigationWrap = styled.header` | |||
position: sticky; | |||
// position: sticky; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove it if not needed, don't keep it as comment
@@ -71,6 +71,7 @@ h2 { | |||
} | |||
.diagram { | |||
margin-bottom:150px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why extra margin?
@@ -64,7 +64,7 @@ body { | |||
transition-timing-function: cubic-bezier(0.2, 0.8, 0.2, 1); | |||
font-family: "Qanelas Soft", "Open Sans", sans-serif; | |||
overflow-x: hidden !important; | |||
// overflow-x: hidden !important; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here remove it
@balagowda incorporate the feedback and rest looks good.✔️ |
Description
This PR fixes #5985
Untitled.mov
Notes for Reviewers
Signed commits