Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

animation div sticky correction #6130

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

balagowda
Copy link
Contributor

@balagowda balagowda commented Dec 23, 2024

Description

This PR fixes #5985

Untitled.mov

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@l5io
Copy link
Contributor

l5io commented Dec 23, 2024

🚀 Preview for commit 9d62e6b at: https://67694a5916d269264ab11c3b--layer5.netlify.app

@@ -1,7 +1,7 @@
import styled from "styled-components";

const NavigationWrap = styled.header`
position: sticky;
// position: sticky;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove it if not needed, don't keep it as comment

@@ -71,6 +71,7 @@ h2 {
}

.diagram {
margin-bottom:150px;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why extra margin?

@@ -64,7 +64,7 @@ body {
transition-timing-function: cubic-bezier(0.2, 0.8, 0.2, 1);

font-family: "Qanelas Soft", "Open Sans", sans-serif;
overflow-x: hidden !important;
// overflow-x: hidden !important;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here remove it

@sudhanshutech
Copy link
Member

@balagowda incorporate the feedback and rest looks good.✔️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Animation vanishes on scrolling
3 participants