Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider renaming NodeImageMode to ImageNodeMode #16909

Open
mgi388 opened this issue Dec 20, 2024 · 0 comments
Open

Consider renaming NodeImageMode to ImageNodeMode #16909

mgi388 opened this issue Dec 20, 2024 · 0 comments
Labels
A-UI Graphical user interfaces, styles, layouts, and widgets C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it!

Comments

@mgi388
Copy link
Contributor

mgi388 commented Dec 20, 2024

  • In 0.15, we now have ImageNode, and I just noticed it has a field image_mode of type NodeImageMode (notice the inconsistency):
pub struct ImageNode {
    /// Controls how the image is altered to fit within the layout and how 
    /// the layout algorithm determines the space to allocate for the image.
    pub image_mode: NodeImageMode,
}
@BenjaminBrienen BenjaminBrienen added D-Trivial Nice and easy! A great choice to get started with Bevy A-UI Graphical user interfaces, styles, layouts, and widgets C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! labels Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-UI Graphical user interfaces, styles, layouts, and widgets C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it!
Projects
None yet
Development

No branches or pull requests

2 participants