[WIP] preferences: Add X button to preference pages. #1160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you mind posting screenshots? Thanks! |
|
Sure @alya
Let me know what you think. |
…nces pages. Addition of X button adds a conventional and convenient method to escape out from settings menu instead of workarounds. Fixes: zulip#1077
manavmehta
force-pushed
the
exit-settings
branch
from
fc1a2f7 to
6914d09
Compare
|
Heads up @manavmehta, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do?
Addition of
Xbutton adds a conventional and convenient method to escape out from settings menu instead of workarounds.The X button is coherent with those used elsewhere in Zulip Web.
Precise, the same css code is used which styles the
Xbutton in all other web setting menus.Fixes: #1077
Flow of the code piece:
Upon clicking on the
Xbutton,base-section.ts/exitSettings()is called.It sends renderer a message to exit settings -> received in
main.ts.Which, finds the last active server tab. If that exists, we switch focus to the same.
Screenshots?
You have tested this PR on: