Remove unused parts of the OpenCV build #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is aruco not needed by wpical anymore? It’s why we added it. |
Gold856
force-pushed
the
clean-up-build
branch
from
32aea05 to
aea9cb6
Compare
|
We still need aruco, but the aruco module has been obsoleted by the objdetect library (has been for a little while), so we don't need the external module. I also tested building wpical with a locally published build of opencv without the aruco module or aruco module headers (just the objdetect headers) and it works, so this should be fine. |
Gold856
force-pushed
the
clean-up-build
branch
from
c4bc540 to
d52266b
Compare
Aruco module has been replaced by objdetect
Gold856
force-pushed
the
clean-up-build
branch
from
d52266b to
587e6d7
Compare
PeterJohnson
approved these changes
Dec 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aruco module has been replaced by objdetect, unused date variables were removed, and manifest blocks that didn't do anything were removed from zip tasks.