-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add methods to get name of SendableChooser's selected value #7580
Open
Braykoff
wants to merge
7
commits into
wpilibsuite:main
Choose a base branch
from
Braykoff:sendable-chooser-value
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+102
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component: wpilibj
WPILib Java
component: wpilibc
WPILib C++
labels
Dec 23, 2024
/format |
/format was removed. You'll have to format manually. |
Braykoff
changed the title
Add methods to get name of SendableChooser's selected value.
Add methods to get name of SendableChooser's selected value
Dec 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! I'm really hopeful that this can make it in before kickoff. Just a few things:
- You can change the first 7 lines of
GetSelected()
(currently 98-104) to juststd::string selected = GetSelectedName();
to match Java. - Java's
testChangeListener()
doesn't have the changes done to C++'sChangeListener
test.
It seems an unrelated test has failed in ubsan:
|
wpilibc/src/main/native/include/frc/smartdashboard/SendableChooser.h
Outdated
Show resolved
Hide resolved
Co-authored-by: Joseph Eng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, such as logging, it can be useful to get the name of a SendableChooser's currently selected option. This adds:
getSelectedName()
/GetSelectedName()
, to get the name of the currently selected optiononChange(BiConsumer<String, V>)
/OnChange(std::function<void(std::string_view, T)> listener)
to get the name when the currently selected option changes. The original onChange methods are kept for backward compatibility.