Support for distribution #2556
Open
Support for distribution #2556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR we introuduce the support for distributing our fork of react-native-calendars.
Compared to how we used to integrate the library, we now build it on this repository, and declare the
destfolder as the folder that needs to be used and bundled for consumption by Ecomm.This has several advantages: first we don't have to think about TS compiling at Ecomm side, just use the JS compiled and the types .d.ts generated. Second the bundles size of the web Ecomm becomes smaller as the TS is not bundled in the (first) chunk. This ideally should also reduce the size of the CodePush bundle.
Only note after the distribution happens we need to manually copy over the imgs since those
BEFORE
AFTER
