Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: re-render on theme prop changes #2540

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: re-render on theme prop changes #2540

wants to merge 1 commit into from

Conversation

aminmeshk
Copy link

See #2539 for explanation.
Added useEffect to update styles when theme prop changes.

@aminmeshk aminmeshk mentioned this pull request Oct 9, 2024
Open
@Norcy
Copy link

Norcy commented Oct 11, 2024

This MR came just in time! I found this bug just a few days ago

MarcosGomesDev
MarcosGomesDev reviewed Oct 19, 2024
View reviewed changes
Copy link

@MarcosGomesDev MarcosGomesDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all is ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcosGomesDev MarcosGomesDev MarcosGomesDev approved these changes

@joaovitorleffa joaovitorleffa joaovitorleffa approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aminmeshk @Norcy @joaovitorleffa @MarcosGomesDev