Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[i18n Ja] Added new translation for the e-commerce guide in Japanese #10122

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

[i18n Ja] Added new translation for the e-commerce guide in Japanese #10122

wants to merge 7 commits into from

Conversation

SnowDingo
Copy link
Contributor

Description

This PR adds a new, fully translated e-commerce guide page in the official Astro docs.
スクリーンショット 2024-12-01 9 01 23

Related issues & labels

  • Suggested label:
    i18n, Japanese, translation

My Username: @SnowDingo (In Discord)

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Dec 1, 2024
@netlify Netlify
Copy link

netlify bot commented Dec 1, 2024 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 5c873ba
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/6762bd0637028700086007cf
😎 Deploy Preview https://deploy-preview-10122--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Dec 1, 2024 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
ja/guides/ecommerce.mdx Localization added, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

staticWagomU
staticWagomU suggested changes Dec 15, 2024
View reviewed changes
Copy link
Contributor

@staticWagomU staticWagomU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

いくつかコメントしましたー！

src/content/docs/ja/guides/ecommerce.mdx Outdated

基礎的な[Lemon.js JavaScript ライブラリ](https://docs.lemonsqueezy.com/help/lemonjs/what-is-lemonjs)を使用することで商品を決済リンクから販売することができます。

#### 基礎的な使用方法
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

他の画面に合わせて基本的な使い方のほうがよいかもしれません
参考：https://docs.astro.build/ja/guides/middleware/#%E5%9F%BA%E6%9C%AC%E7%9A%84%E3%81%AA%E4%BD%BF%E3%81%84%E6%96%B9

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

了解です。基本的な使い方に変更しておきました。

src/content/docs/ja/guides/ecommerce.mdx Outdated

[Paddle.js](https://developer.paddle.com/paddlejs/overview)はPaddleを使用して統合されたサブスクリプション請求体験を構築できる軽量なJavaScriptライブラリーです。

#### 基礎的な使用方法
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

こちらも同様に他の画面に合わせて基本的な使い方のほうがよいかもしれません

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

了解です。承認しておきます。

src/content/docs/ja/guides/ecommerce.mdx Outdated Show resolved Hide resolved
src/content/docs/ja/guides/ecommerce.mdx Outdated
完成済みのSnipCartソリューションが必要ですか？ SnipCartアカウントと連携するだけで使える機能的なAstroのコミュニティテンプレートの[`astro-snipcart`](https://astro-snipcart.vercel.app/)を確認してみてください。
:::

#### 基礎的な使用方法
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

こちらも同様に基本的な使い方のほうがよいかもしれません

@SnowDingo
Copy link
Contributor Author

いくつかコメントしましたー！

@staticWagomU さん、レビューありがとうございます。変更点を確認した所全て良さそうだったので翻訳を少し変更しておきました。
お手数おかけしますが、変更版をもう一度確認していただくことは可能ですか？

よろしくお願いします。

staticWagomU
staticWagomU suggested changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@staticWagomU staticWagomU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ごめんなさい！ほかの場所にもあるのでこれらも修正お願いいたしますーー

src/content/docs/ja/guides/ecommerce.mdx Outdated Show resolved Hide resolved
src/content/docs/ja/guides/ecommerce.mdx Outdated Show resolved Hide resolved
src/content/docs/ja/guides/ecommerce.mdx Outdated Show resolved Hide resolved
@SnowDingo
Copy link
Contributor Author

ごめんなさい！ほかの場所にもあるのでこれらも修正お願いいたしますーー

変更しておきました！
再度確認お願いします🙇

staticWagomU
staticWagomU approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@staticWagomU staticWagomU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます！！！
LGTMです！！

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staticWagomU staticWagomU staticWagomU approved these changes

Assignees
No one assigned
Labels
i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SnowDingo @astrobot-houston @staticWagomU @yanthomasdev