Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: only care about the empty string when beStrict is false #845

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Editorial: only care about the empty string when beStrict is false #845

merged 2 commits into from
Dec 2, 2024

Conversation

annevk
Copy link
Member

@annevk annevk commented Dec 2, 2024 •
edited by pr-preview bot
Loading

VerifyDnsLength will take care of it otherwise. (See #497 for additional context.)

Preview | Diff

@annevk
Editorial: only care about the empty string when beStrict is false
acbcafd 
VerifyDnsLength will take care of it otherwise. (See #497 for additional context.)
@annevk annevk requested review from hsivonen and rmisev December 2, 2024 09:33
hsivonen
hsivonen approved these changes Dec 2, 2024
View reviewed changes
Copy link
Member

@hsivonen hsivonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Step 4 could use a note to mention that if beStrict is true, the assertion holds for UTS 46 reasons.

r+ with or without the note, though.

@annevk annevk merged commit 7f3e3b6 into main Dec 2, 2024
2 checks passed
@annevk annevk deleted the domain-to-ascii-empty-string branch December 2, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmisev rmisev rmisev approved these changes

@hsivonen hsivonen hsivonen approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@annevk @hsivonen @rmisev