[wdspec] change test_..._closes_browsing_context #49765
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Classic tests. Open context with `window.open` to allow it to be closed by script.
wpt-pr-bot
requested review from
AutomatedTester,
jgraham,
juliandescottes and
shs96c
|
@whimboo it looks like this functionality does not work properly on ChromeDriver Classic, so I cannot verify if the test actually works. Could you please confirm it works for Firefox? |
whimboo
requested changes
Dec 19, 2024
|
|
||
| # Open a new window. | ||
| resp = session.execute_script(f"return window.open('{url}')") | ||
| new_window_handle = resp.id |
There was a problem hiding this comment.
What is response id? It's most likely not a webdriver specific window handle but just the id of the opened window. So it cannot be referenced for setting the window handle below.
You will have to check all the open window handles and find the one that was not open before. Most likely some tests might already do that.
| with pytest.raises(NoSuchWindowException): | ||
| key_chain.key_down("w") \ | ||
| .pause(100 * configuration["timeout_multiplier"]) \ | ||
| .pause(250 * configuration["timeout_multiplier"]) \ |
There was a problem hiding this comment.
Is there a reason why you increase the timeout? We had to do it in bidi due to an issue in Firefox that I'm going to fix soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Classic tests. Open context with
window.opento allow it to be closed by script.