-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define the scope of web-platform-tests #215
Open
gsnedders
wants to merge
2
commits into
web-platform-tests:master
Choose a base branch
from
gsnedders:scope-of-wpt
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,60 @@ | ||
# RFC 215: Defining the Scope of web-platform-tests | ||
|
||
### Summary | ||
|
||
Define the scope of web-platform-tests to specifications which might reasonably be called "web specifications" | ||
and which are intended to be implemented by web browsers. | ||
|
||
Additionally, define what "tentative" might reasonably be used for. | ||
|
||
This is intended to codify existing practice, | ||
rather than represent any change. | ||
|
||
|
||
### Details | ||
|
||
Historically, what's been in scope for web-platform-tests has been somewhat nebulous, | ||
and largely based on a common understanding of participants, | ||
especially those on the Core Team. | ||
We should put this on surer footing, | ||
and make it easier for others to understand what is and isn't reasonable to add. | ||
|
||
The primary aim of web-platform-tests is to test | ||
[web specifications](https://github.com/w3c/browser-specs/blob/11a71b738f5e41f9239fdcd2074153388c8c6b8b/README.md#spec-selection-criteria) | ||
[intended to be implemented by browsers](https://github.com/w3c/browser-specs/blob/11a71b738f5e41f9239fdcd2074153388c8c6b8b/README.md#categories), | ||
both RFC 2119 "must" and RFC 2119 "should" | ||
implementation requirements. | ||
|
||
A specification does not need to have cross-vendor support for its tests to be included in web-platform-tests. | ||
(XXX: Should we set a bar of one-vendor support or are we okay with zero-vendor support?) | ||
|
||
Additionally, other features can be added as | ||
[tentative](https://web-platform-tests.org/writing-tests/file-names.html#:~:text=.tentative,-%3A%20) | ||
tests: | ||
|
||
* Web browser behavior currently being explored via an | ||
[explainer](https://tag.w3.org/explainers/), | ||
but without a specification yet written. | ||
(XXX: require prototyping to have started?) | ||
|
||
* Historic but unspecified features in web browsers, | ||
especially where major browsers are interoperable, | ||
where there exists a long-term intention to specify them. | ||
(Note: this excludes features which have been deliberately removed from specifications. | ||
These are explicitly out of scope.) | ||
|
||
Features which are optional | ||
(in RFC 2119 terms: | ||
where the conformance criteria is | ||
"may" or "may not") | ||
may be included as | ||
[optional tests](https://web-platform-tests.org/writing-tests/file-names.html#:~:text=.optional,-%3A%20) | ||
or | ||
[optional subtests](https://web-platform-tests.org/writing-tests/testharness-api.html#optional-features). | ||
|
||
|
||
### Risks | ||
|
||
We over-constrain what is allowed in web-platform-tests, | ||
potentially raising the bar to change what is allowed to "submit a new RFC", | ||
leading browser vendors to reduce what they submit to the project. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This arguably doesn't actually match up with what the documentation currently says:
The "in contradiction to some specification" is kinda troubling — this implies that if some spec change is made, with no expectation of implementations changing behaviour any time soon, you could change the existing tests to be tentative and add new non-tentative tests for the new behaviour. IMO, that should be against policy — anything that is tentative should be on a path to becoming non-tentative. We should probably be explicit in the scope of what can be tentative that everything which is tentative should be on a path to becoming non-tentative.
I don't think the two things listed here are a complete list of cases; we also have cases:
/css/css-overflow/line-clamp/line-clamp-005.tentative.html
is an example of this, with [css-overflow] Is continue: discard working in the fragment tree useful? w3c/csswg-drafts#7708 (comment)),svg-aam/role/role-img.tentative.html
, with SVG image role should align with HTML on missing versus empty alt w3c/svg-aam#32),/html/dom/elements/global-attributes/the-anchor-attribute-001.tentative.html
, with Add anchor attribute whatwg/html#9144),webdriver/tests/bidi/input/release_actions/sequence_tentative.py
, with Should a navigation clean-up thebrowsing context input state map
? w3c/webdriver#1859).The other thing that stands out is:
Which shows it's very often not obvious "why the test is tentative and what needs to be resolved to make it non-tentative", though that is really a separate issue. (And looking at a few random tests, the commit history often doesn't make it obvious either.)