Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-view-transitions-1] Don't animate transform/size by default when prefers-reduced-motion is on #10996

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

noamr
Copy link
Collaborator

@noamr noamr commented Oct 3, 2024

Closes #10267

@noamr noamr requested a review from khushalsagar October 3, 2024 09:51
@@ -1538,6 +1538,14 @@ urlPrefix: https://wicg.github.io/navigation-api/; type: interface;
backdrop-filter: <var>backdropFilter</var>;
}
}

@media (prefers-reduced-motion) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The thinking here was to reset the animation property on the group pseudo instead of modifying the keyframe. So if the author does want to reinstate the size/position animation they'll have access to the keyframe. But I didn't realize that other properties are part of this keyframe too.

And actually more will be added with the new capture mode.

@@ -1538,6 +1538,14 @@ urlPrefix: https://wicg.github.io/navigation-api/; type: interface;
backdrop-filter: <var>backdropFilter</var>;
}
}

@media (prefers-reduced-motion) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a WPT test for this? Asking b/c I don't know offhand if the user preference media features can be tested in WPT. If not, merging this PR may be dependent on that test-ability requirement.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not currently testable. See web-platform-tests/wpt#14839

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[css-view-transitions] Users need to be able to disable view transitions
3 participants