Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: changed lifecycle hooks to be after components basics in sidebar #3125

Merged
merged 3 commits into from
Dec 9, 2024

Conversation

kvanvigs
Copy link
Contributor

@kvanvigs kvanvigs commented Dec 7, 2024

Description of Problem

Components basics should be addressed before the component lifecycle hooks. According to issue #3094.

Proposed Solution

I changed the Lifecycle hooks tab to be last in the sidebar due to a suggestion that it would "fit the narrative" better.

It was stated that Lifecycle hooks should be at the end of the essentials tab because it fits the narrative better. vuejs#3094
Copy link

netlify bot commented Dec 7, 2024

Deploy Preview for vuejs ready!

Name Link
🔨 Latest commit ae3cbb7
🔍 Latest deploy log https://app.netlify.com/sites/vuejs/deploys/6753d8b40314e300084712da
😎 Deploy Preview https://deploy-preview-3125--vuejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kvanvigs kvanvigs changed the title Fixed Issue #3094 docs: changed lifecycle hooks to be after components basics #3094 Dec 7, 2024
@kvanvigs kvanvigs changed the title docs: changed lifecycle hooks to be after components basics #3094 docs: changed lifecycle hooks to be after components basics issue #3094 Dec 7, 2024
@kvanvigs kvanvigs changed the title docs: changed lifecycle hooks to be after components basics issue #3094 docs: changed lifecycle hooks to be after components basics Dec 7, 2024
@kvanvigs kvanvigs changed the title docs: changed lifecycle hooks to be after components basics docs: changed lifecycle hooks to be after components basics in sidebar Dec 7, 2024
@NataliaTepluhina NataliaTepluhina linked an issue Dec 9, 2024 that may be closed by this pull request
@NataliaTepluhina NataliaTepluhina merged commit 7d15b57 into vuejs:main Dec 9, 2024
5 checks passed
szymonlicau pushed a commit to monterail/vue3-docs-pl that referenced this pull request Dec 9, 2024
vuejs#3125)

* Add files via upload

tesst

* Delete test.txt

* Fixed issue vuejs#3094

It was stated that Lifecycle hooks should be at the end of the essentials tab because it fits the narrative better. vuejs#3094
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Lifecycle Hooks" page feels out of place in the current order
2 participants