Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added export in EventHandlers type #12586

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

FukaYouTube
Copy link

@FukaYouTube FukaYouTube commented Dec 20, 2024

-> export type EventHandlers = {

When developing my own component, I wanted to use custom props as onClick, onFocus.

I noticed that they are not in runtime or I did not find them, I thought it would be better to add export for the type that will allow me to use for my components

@edison1105
Copy link
Member

Could you please provide more information?

@edison1105 edison1105 added the need more info Further information is requested label Dec 23, 2024
@FukaYouTube
Copy link
Author

Could you please provide more information?

When developing my own component, I wanted to use custom props as onClick, onFocus.

I noticed that they are not in runtime or I did not find them, I thought it would be better to add export for the type that will allow me to use for my components

@edison1105 edison1105 added ready to merge The PR is ready to be merged. 🧹 p1-chore Priority 1: this doesn't change code behavior. and removed need more info Further information is requested labels Dec 23, 2024
Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB 37.9 kB 34.2 kB
vue.global.prod.js 158 kB (+15 B) 57.8 kB (+6 B) 51.4 kB (+26 B)

Usages

Name Size Gzip Brotli
createApp (CAPI only) 46.6 kB (+350 B) 18.3 kB (+116 B) 16.7 kB (+105 B)
createApp 54.6 kB (+366 B) 21.3 kB (+136 B) 19.4 kB (+153 B)
createSSRApp 58.7 kB (+253 B) 23 kB (+118 B) 20.9 kB (+87 B)
defineCustomElement 59.4 kB (+368 B) 22.8 kB (+138 B) 20.8 kB (+111 B)
overall 68.4 kB (+132 B) 26.4 kB (+59 B) 24 kB (+116 B)

Copy link

pkg-pr-new bot commented Dec 23, 2024

Open in Stackblitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@12586

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@12586

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@12586

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@12586

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@12586

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@12586

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@12586

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@12586

@vue/shared

npm i https://pkg.pr.new/@vue/shared@12586

vue

npm i https://pkg.pr.new/vue@12586

@vue/compat

npm i https://pkg.pr.new/@vue/compat@12586

commit: 86800e3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧹 p1-chore Priority 1: this doesn't change code behavior. ready to merge The PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants