Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump @types/chai to 5.0.1 #7123

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

nopeless
Copy link
Contributor

Description

#7121 cc @hi-ogawa

fix broken vitest assert types

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci. (vitest/test/config/fixtures/exec-args-fixtures/vmThreads.test.ts fails for some reason)

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@nopeless
Copy link
Contributor Author

note: I haven't actually checked if the typings work now, but based on a simple diff between v4 and v5, I concluded that bumping the version will fix the issue

@nopeless
Copy link
Contributor Author

welp ci is breaking, idk y

@nopeless
Copy link
Contributor Author

nopeless commented Dec 24, 2024

I am not entirely sure why 2130edc is required for build to succeed. I am also not sure why simply building the repository causes cced3ff either

Copy link

netlify bot commented Dec 24, 2024

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 11d8c77
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/676bb5a647437300084b7f36
😎 Deploy Preview https://deploy-preview-7123--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nopeless
Copy link
Contributor Author

ci based tdd

@nopeless
Copy link
Contributor Author

found out the type issue

Caused by this commit 5f4774f

I am not sure why he is inlining chai types when he already patched it? anyway, this is out of my decision.

This was not an issue in the previous @types/chai

4.3.6

declare namespace Chai {

5.0.1

declare global {
    namespace Chai {

@sheremet-va I would like to know how you would approach this issue

also I am not willing to fix the failing test as I have no idea why it fails

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant