chore: add missing geo distance type on hits #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codingwithchris
changed the title
jasonbosco
requested changes
Aug 9, 2022
| @@ -70,6 +70,9 @@ export interface SearchResponseHit<T extends DocumentSchema> { | |||
| matched_tokens: string[]; | |||
| } | |||
| ]; | |||
| geo_distance_meters?: { | |||
| location?: number; | |||
There was a problem hiding this comment.
location is actually the name of the geopoint field from the document. So this needs to be a dynamic type which allows keys with the same name as any of the document's fields...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Adding missing
geo_distance_meterstype inSearchResponseHitinterface.PR Checklist
Questions.
Is
locationtruly optional in this instance? Could we hit a case where ageo_distance_metersparameter is returned but location doesn't exist or has an undefined value?