[ISSUE 14] - Add Material UI throughout app #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ponent instead of label tag; change color of elements
- update imports; - add MUI components; - add Tooltips.
- add MUI components, such as Paper and Typography; - add minor custom styling to MUI Paper; - update input placeholder and label.
kweeuhree
requested review from
ahsanatzapier,
jendevelops and
deeheber
as code owners
|
Visit the preview URL for this PR (updated for commit d6e08d8): https://tcl-75-smart-shopping-list--pr75-nk-add-mui-throughou-uby9t9bt.web.app (expires Fri, 25 Oct 2024 12:18:52 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 1f1fd53c369e1fa31e15c310aa075b4e8f4f8dde |
kweeuhree
changed the title
kweeuhree
added
enhancement
…-shopping-list into nk-add-mui-throughout-app
…Items component if clicked
…ary color in two variants: darkPaperStyle and lightPaperStyle
granolagabrielle
approved these changes
Oct 18, 2024
There was a problem hiding this comment.
@kweeuhree this one also looks good to me. Tested locally and everything works.
The preview link didn't work again, but I'm not sure why.
warrenchan13
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This code adds Material UI components throughout the app. Some of the previous custom styling is removed for simplicity. However, some of custom styling is still added, such as border color, font size and color changes.
The following Material components have been added:
Additionally this code proposes some changes to some of input labels and placeholders. Changes aim to make such prompts more friendly and descriptive.
Tests are updated to reflect changes made in labels and placeholders.
Related Issue
Closes #14
Type of Changes
enhancementUpdates
Before
Home:
List:
ManageList:
After
Home:
List:
Empty list:
List with items:
List with items with AddItems visible:
ManageList:
Testing Steps / QA Criteria