-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix[Modified] UI Text Style Changed for Professional Look #93
base: master
Are you sure you want to change the base?
Conversation
Deploy preview for rne-playground ready! Built with commit 56f332b |
@pranshuchittora @Uyadav207 please look into it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your feedback. On it. |
toggleButton_for_MobileView.mov@shivambalwani @pranshuchittora @flyingcircle can you please look into it ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice initiative, @piyushdevOP, but changing fonts doesn't add much... Try any other possible way to enhance the UI.
|
hey thanks for the feedback. I will revert back the fonts and come up with some better UI changes and effects if it's fine? |
@Uyadav207 @shivambalwani @pranshuchittora I have restored the font back and added the rocket symbol. I haven't put the effects yet because I didn't get any go from you guys. Please do provide your valuable feedback. Should I do it? font_restored.mov |
Oops! Conflicts. |
Esteemed Sir, the burger button display issue in mobile view is fixed in this PR only. Should I go ahead and resolve the conflicts so that the mobile view issue could be fixed? It would be great of you if you could tell me how to proceed . |
@shivambalwani @Uyadav207 kindly look into it. I was facing some dependency issues. I have fixed it.Please do suggest some changes if required. |
React View ?? |
Something like V8 was missing. I have resolved the conflicts. It would be of great help if you could tell me what I have done is acceptable or not. I am kinda new to open source 😃 |
*What kind of change does this PR introduce?
UI look change.
Did you add tests for your changes?
No
Summary
It was done to provide more professional look to the webapp.
Does this PR introduce a breaking change?
No
Other information