Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix[Modified] UI Text Style Changed for Professional Look #93

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

piyushdevOP
Copy link

*What kind of change does this PR introduce?
UI look change.

Did you add tests for your changes?
No

Summary

It was done to provide more professional look to the webapp.

Does this PR introduce a breaking change?

No

Other information

@netlify
Copy link

netlify bot commented Mar 22, 2021

Deploy preview for rne-playground ready!

Built with commit 56f332b

https://deploy-preview-93--rne-playground.netlify.app

@piyushdevOP piyushdevOP changed the title [Modified] UI Text Style Changed for Professional Look fix [Modified] UI Text Style Changed for Professional Look Mar 22, 2021
@piyushdevOP
Copy link
Author

@pranshuchittora @Uyadav207 please look into it.

Copy link

@shivambalwani shivambalwani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-> The UI is breaking , in mobile view there is no proper styling
and spacing in the page title as well as in the navbar title.
-> The Navbar seems to be missing as well.
I don't think this change looks professional.
Try fixing these issues.
Screenshot 2021-03-23 at 8 53 40 AM

@piyushdevOP
Copy link
Author

Thank you for your feedback. On it.

@piyushdevOP
Copy link
Author

piyushdevOP commented Mar 23, 2021

-> The UI is breaking , in mobile view there is no proper styling
and spacing in the page title as well as in the navbar title.
-> The Navbar seems to be missing as well.
I don't think this change looks professional.
Try fixing these issues.
Screenshot 2021-03-23 at 8 53 40 AM

toggleButton_for_MobileView.mov

@shivambalwani @pranshuchittora @flyingcircle can you please look into it ?
If there are any effects to be added to the UI , do let me know. I have some really good ideas for it.

Copy link

@shivambalwani shivambalwani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--> The font styling is not Accurate compare it with original one.
-->Just a Suggestion Rocket icon 🚀 on the nav bar looked great.
Refer to Screen shots below:
Screenshot 2021-03-23 at 9 18 07 PM
Screenshot 2021-03-23 at 9 19 52 PM

@piyushdevOP
Copy link
Author

--> The font styling is not Accurate compare it with original one.
-->Just a Suggestion Rocket icon 🚀 on the nav bar looked great.
Refer to Screen shots below:
Screenshot 2021-03-23 at 9 18 07 PM
Screenshot 2021-03-23 at 9 19 52 PM

Thank you for your feedback. I tried changing the fontStyle to give a modern look to the UI. I can revert it if it's not looking nice.

@Uyadav207
Copy link
Contributor

Uyadav207 commented Mar 23, 2021

@pranshuchittora @Uyadav207 please look into it.

Nice initiative, @piyushdevOP, but changing fonts doesn't add much... Try any other possible way to enhance the UI.

  • only Revert the Fonts back.... Leave Mobile View as it is
  • The Icon Rocket looks great over there. isn't it ??

@piyushdevOP
Copy link
Author

@pranshuchittora @Uyadav207 please look into it.

Nice initiative, @piyushdevOP, but changing fonts doesn't add much... Try any other possible way to enhance the UI.

  • only Revert the Fonts back.... Leave Mobile View as it is
  • The Icon Rocket looks great over there. isn't it ??

hey thanks for the feedback. I will revert back the fonts and come up with some better UI changes and effects if it's fine?

@piyushdevOP
Copy link
Author

piyushdevOP commented Mar 25, 2021

@Uyadav207 @shivambalwani @pranshuchittora I have restored the font back and added the rocket symbol. I haven't put the effects yet because I didn't get any go from you guys. Please do provide your valuable feedback. Should I do it?
fixes #86

font_restored.mov

@piyushdevOP piyushdevOP changed the title fix [Modified] UI Text Style Changed for Professional Look fix #86 [Modified] UI Text Style Changed for Professional Look Mar 25, 2021
@piyushdevOP piyushdevOP changed the title fix #86 [Modified] UI Text Style Changed for Professional Look fix[Modified] UI Text Style Changed for Professional Look Mar 25, 2021
@pranshuchittora
Copy link
Member

Oops! Conflicts.
I think this is not required

@piyushdevOP
Copy link
Author

Oops! Conflicts.
I think this is not required

Esteemed Sir, the burger button display issue in mobile view is fixed in this PR only. Should I go ahead and resolve the conflicts so that the mobile view issue could be fixed? It would be great of you if you could tell me how to proceed .

@piyushdevOP piyushdevOP reopened this Mar 26, 2021
@piyushdevOP
Copy link
Author

@shivambalwani @Uyadav207 kindly look into it. I was facing some dependency issues. I have fixed it.Please do suggest some changes if required.

@Uyadav207
Copy link
Contributor

@shivambalwani @Uyadav207 kindly look into it. I was facing some dependency issues. I have fixed it.Please do suggest some changes if required.

React View ??

@piyushdevOP
Copy link
Author

@shivambalwani @Uyadav207 kindly look into it. I was facing some dependency issues. I have fixed it.Please do suggest some changes if required.

React View ??

Something like V8 was missing. I have resolved the conflicts. It would be of great help if you could tell me what I have done is acceptable or not. I am kinda new to open source 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants