Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 3147: Update figures #4178

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

shallow-beach
Copy link

@shallow-beach shallow-beach commented Dec 20, 2024

There was a little bit of missing background in the png for the figure, went in and fixed that. To do so, I had to get Dia running on MacOS 15 which was a nightmare (booting the app via XQuartz terminal 🥴), so also rendered out the dia file into an svg for ease of future contributors.


📚 Documentation preview 📚: https://pep-previews--4178.org.readthedocs.build/

@shallow-beach shallow-beach requested review from warsaw and a team as code owners December 20, 2024 19:58
Copy link

cpython-cla-bot bot commented Dec 20, 2024

All commit authors signed the Contributor License Agreement.
CLA signed

Copy link
Author

@shallow-beach shallow-beach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restored figure sizing so png displays properly in docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant