Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-128234: support emscripten and wasi in async contextlib tests, by removing asyncio from contextlib async tests #95888

Merged
merged 6 commits into from
Dec 25, 2024
Merged

gh-128234: support emscripten and wasi in async contextlib tests, by removing asyncio from contextlib async tests #95888

merged 6 commits into from
Dec 25, 2024
+61 −33

Conversation

graingert
Copy link
Contributor

@graingert graingert commented Aug 11, 2022 •
edited by bedevere-app bot
Loading

@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Aug 11, 2022
@graingert graingert requested a review from iritkatriel August 11, 2022 14:25
@graingert graingert mentioned this pull request Aug 11, 2022
Open
@graingert graingert changed the title remove asyncio from contextlib async tests support emscrpten and wasi in async contextlib tests, by removing asyncio from contextlib async tests Dec 25, 2024
@graingert graingert force-pushed the remove-asyncio-from-contextlib-async-tests branch from 61f0545 to 0461429 Compare December 25, 2024 08:22
@graingert graingert marked this pull request as ready for review December 25, 2024 08:23
@graingert graingert requested a review from 1st1 as a code owner December 25, 2024 08:23
@graingert graingert changed the title support emscrpten and wasi in async contextlib tests, by removing asyncio from contextlib async tests gh-128234: support emscrpten and wasi in async contextlib tests, by removing asyncio from contextlib async tests Dec 25, 2024
@bedevere-app bedevere-app bot mentioned this pull request Dec 25, 2024
Closed
@graingert graingert changed the title gh-128234: support emscrpten and wasi in async contextlib tests, by removing asyncio from contextlib async tests gh-128234: support emscripten and wasi in async contextlib tests, by removing asyncio from contextlib async tests Dec 25, 2024
asvetlov
asvetlov approved these changes Dec 25, 2024
View reviewed changes
Copy link
Contributor

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@kumaraditya303 kumaraditya303 enabled auto-merge (squash) December 25, 2024 11:53
@kumaraditya303 kumaraditya303 merged commit 81636d3 into python:main Dec 25, 2024
36 checks passed
@graingert graingert deleted the remove-asyncio-from-contextlib-async-tests branch December 25, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

@asvetlov asvetlov asvetlov approved these changes

@iritkatriel iritkatriel Awaiting requested review from iritkatriel

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@graingert @asvetlov @kumaraditya303 @bedevere-bot