Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-128002: use internal llist implementation for asyncio tasks #128256

Merged
merged 2 commits into from
Dec 25, 2024
Merged

gh-128002: use internal llist implementation for asyncio tasks #128256

merged 2 commits into from
Dec 25, 2024
+20 −50

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Dec 25, 2024 •
edited by bedevere-app bot
Loading

This refactor would help further experimentation like moving to per-thread asyncio tasks lists etc.

@bedevere-app bedevere-app bot mentioned this pull request Dec 25, 2024
Open
9 tasks
picnixz
picnixz approved these changes Dec 25, 2024
View reviewed changes
Copy link
Contributor

@picnixz picnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit and LGTM.

Modules/_asynciomodule.c Outdated Show resolved Hide resolved
@kumaraditya303 kumaraditya303 merged commit 76f1785 into python:main Dec 25, 2024
39 checks passed
@kumaraditya303 kumaraditya303 deleted the llist branch December 25, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@picnixz picnixz picnixz approved these changes

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@willingc willingc Awaiting requested review from willingc willingc is a code owner

Assignees
No one assigned
Labels
skip news topic-asyncio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kumaraditya303 @picnixz