gh-114272: fix Windows test_asyncio/test_subprocess when sys.executable contains unescaped spaces

[andyrosa2]

gh-114272: Fix or skip tests that fail due to spaces in paths

Defines and uses the function get_quoted_sys_executable
if sys.executable is not quoted and it has unescaped spaces, it adds them. Win32 and Linux aware.

def get_quoted_sys_executable():
    if hasattr(get_quoted_sys_executable, '_cached_get_quoted_sys_executable'):
        return get_quoted_sys_executable._cached_get_quoted_sys_executable

    sysExecutable = sys.executable
    if not ((sysExecutable.startswith('"') and sysExecutable.endswith('"')) or 
        (sysExecutable.startswith("'") and sysExecutable.endswith("'"))):
        if ' ' in (sysExecutable if sys.platform == 'win32' else sysExecutable.replace('\\ ', '')):
            sysExecutable = f'"{sysExecutable}"'

    get_quoted_sys_executable._cached_get_quoted_sys_executable = sysExecutable
    return sysExecutable

[cpython-cla-bot]

All commit authors signed the Contributor License Agreement.

[bedevere-app]

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

[picnixz]

Are these the only tests that need modification or are there more that can be fixed?

[picnixz]

Can you refactor the function and use shorter names for the attributes? it's a test file so it doesn't matter what we use. Or use an LRU-cache instead. OTOH, you can setup the test cases so that they have a test attribute (namely cls.sysexec = ... in setUpClass and you'd use as self.sysexec instead of sys.executable in the tests)

[andyrosa2]

Hi picnixz.
I think caching is overkill. I'd do it for my own code but not for opensource to keep it simple. I'll remove it.

[picnixz]

Can't we use some smarter escape mechanism? for instance, something in os.path or shlex.quote perhaps?

[andyrosa2]

os.path does not add the quotes and shlex.quote quotes a quoted string ad-nauseam.
i think we should merge this have less failed tests, and somebody later (maybe me) should fix shlex.quote

[andyrosa2]

*fewer failed test
I do not know if other libraries should benefit from this . I just run python -m unittest for the first time, and the only failures are fixed by this. There are some skips, but that's also for another time.

[picnixz]

cc @zooba for how we should proceed here.