Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix include_declaration handling in references request #440

Merged
merged 2 commits into from
Sep 10, 2023

Conversation

krassowski
Copy link
Contributor

Fixes #439. The recommendation not to use default values was confirmed by a pluggy maintainer: pytest-dev/pluggy#442 (comment).

@ccordoba12 ccordoba12 added this to the v1.8.1 milestone Sep 10, 2023
@ccordoba12 ccordoba12 added the bug Something isn't working label Sep 10, 2023
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @krassowski!

@ccordoba12 ccordoba12 merged commit 8377b2c into python-lsp:develop Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

includeDeclaration is no longer respected in textDocument/references
2 participants