-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Live server subprocess #47
base: master
Are you sure you want to change the base?
Conversation
Hi @fuhrysteve! This changes looks good for me. But It would be great if |
@@ -34,35 +36,38 @@ def login(self, email, password): | |||
return self.client.post(url_for('login'), data=credentials) | |||
|
|||
def test_login(self): | |||
assert self.login('vital@example.com', 'pass').status_code == 200 | |||
assert self.login('vital@foo.com', 'pass').status_code == 200 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Example.com, example.net, example.org, and example.edu are second-level domain names reserved for documentation purposes and examples of the use of domain names.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll change it back - I was just trying to get the line to squeeze into 80 chars so my pep8 checker would stop complaining :)
Use the separate |
@vitalk So I think the issue with always making So I'm not sure how to make it optionally available unless there's some way I'm not aware of to get a fixture at runtime. Any suggestions? |
@vitalk with regards to |
I missed that part, maybe I can find a workaround. |
Please don't merge this yet. There is still one test that is not passing for a mysterious reason, and additionally this code still needs test cases of its own.
I'm working on a way to launch flask as a completely separate process using
os.fork
by way ofwatcher_getter
(from pytest-services).The reason I need to use this strategy is that SQLAlchemy configurations become considerably more complex when you have to deal with multiprocessing (see docs). I was struggling to get it to work in my existing configuration, and this seemed like the easier option.
Let me know if you have any initial feedback and I'll circle back. Thanks @vitalk!