Async steps #609
Draft
Async steps #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test was failing when run as part of the entire test suite and passing when run on its own. When the first part of the expected[0].id path was changed from test_step_trace0 to test_step_trace1, the results reversed - it passed as part of the entire suite and failed on its own. This behavior was not observed prior to the async changed. I suspect that this is caused by the addition of test_async_steps.py::test_step_trace, which caused this to no longer be the first test with the name `test_step_trace` to run as part of the entire suite. Since there are several other tests with the same name, it seems like the best course here would be to ensure that this test has a unique name so that it is more resilient to ordering.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another start at #223. It seems as though some of the previous cracks at it have stalled, and with there being some significant changes to the baseline overall since those were opened (notably implementing steps as fixtures), I don't think those look too salvageable in their current form. This provides wrappers for step functions when declared as async, the wrapping logic is pretty closely based on what pytest-asyncio does for their
@async_fixture(but this does not add pytest-asyncio as a requirement).Things that might want to be considered:
is_asyncis set, then raise an error if the function is not async.event_loopfixture if enabled/available).