Cryptoreader #917
Open
Cryptoreader #917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deleted exchanges without historic-rates request Refactoring
-More Unit-Tests -Refactoring
…ng is done. - Added CryptoReader.check_symbols() to check if the symbols are available at an exchange.
- Bugfix CryptoReader._check_symbols - Bugfix reset _BaseReader after a complete run.
-Implemented predefined _BaseReader methods.
- Updated requirements
-Bugfix Coinpaprika splitting currency-pairs. -Currency-pair split now with "/", e.g. btc/usd.
-Bugfix Coinpaprika splitting currency-pairs. -Currency-pair split now with "/", e.g. btc/usd.
|
Which black are you using? I'm surprised 93 files have been changed. |
|
Hi @bashtage! I'm using Black version 19.10b0. Most changes are due to new yaml-files (78 in total), each file represents a cryptocurrency exchange (in the directory crypto_utils/resources/). Within the already existing Python files, I made changes in the following 3; while 8 more files are added for the CryptoReader to work:
Best! |
-Fixed splitting parameter for platforms -New unit tests -Adjusted parameter order for CryptoReader to match the DataReader
-Listed currency-pair request simplified -Some small bug fixes
-Refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diffblack --check pandas_datareader