Add simple stats API #242
Open
Add simple stats API #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: José Ulises Niño Rivera <[email protected]>
adilhafeez
reviewed
Jul 11, 2024
Signed-off-by: José Ulises Niño Rivera <[email protected]>
adilhafeez
approved these changes
Jul 15, 2024
Swaagie
requested changes
Nov 28, 2024
There was a problem hiding this comment.
I've actually tested this local on a project and it works nicely. @PiotrSikora what is your opinion on this vs the other metric PR?
| @@ -0,0 +1,32 @@ | |||
| ## Proxy-Wasm plugin example: HTTP headers | |||
There was a problem hiding this comment.
Suggested change
| ## Proxy-Wasm plugin example: HTTP headers | |
| ## Proxy-Wasm plugin example: Metrics |
| @@ -0,0 +1,32 @@ | |||
| ## Proxy-Wasm plugin example: HTTP headers | |||
|
|
|||
| Proxy-Wasm plugin that logs HTTP request/response headers. | |||
There was a problem hiding this comment.
Please update this as well.
| ### Building | ||
|
|
||
| ```sh | ||
| $ cargo build --target wasm32-wasi --release |
There was a problem hiding this comment.
Suggested change
| $ cargo build --target wasm32-wasi --release | |
| $ cargo build --target wasm32-wasip1 --release |
|
|
||
| services: | ||
| envoy: | ||
| image: envoyproxy/envoy:v1.24-latest |
There was a problem hiding this comment.
Suggested change
| image: envoyproxy/envoy:v1.24-latest | |
| image: envoyproxy/envoy:v1.31-latest |
| direct_response: | ||
| status: 200 | ||
| body: | ||
| inline_string: "Request /hello and be welcomed!\n" |
There was a problem hiding this comment.
Leave a more specific helpful message that explains what header to set. In addition IMHO it might be useful to have the WASM filter return the current values of metrics in the response without having to check the /stats endpoint. This would make the example more Envoy agnostic as well.
| use crate::types; | ||
|
|
||
| #[derive(Copy, Clone)] | ||
| pub struct Counter { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes the concept of Metrics with a high level API. It takes liberal inspiration from the Simple<Counter,Gauge,Histogram> in the CPP SDK.
Users of the Rust SDK will now be able to create and manipulate simple Counters, Gauges, and Histograms that exist in the Envoy Runtime.
Note that this change is more generic than #229 given that it exposes the concept of Counters, Gauges, and Histograms as a first class implementation, rather than interacting directly with the metrics host calls via the Root Context.
cc @casimiro