New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor MobileNav for handling mobile title more efficiently #3310

Open

Rajnish2105 wants to merge 2 commits into processing:develop from Rajnish2105:refactor-swtichToProps-MobileTitle

+64 −24

Rajnish2105 commented Dec 25, 2024 •

edited

Loading

Refactior: TODO: remove the switch and use a props like mobileTitle

Changes:

I have moved the switch logic to the useWhatPage hook to maintain clean and modular code while ensuring the app's functionality remains intact.
Instead of passing MobileTitle as a prop, I shifted the logic to the useWhatPage hook. This approach provides a cleaner and more optimized solution by deriving the title directly from the function.

I have verified that this pull request:

has no linting errors (npm run lint)
has no test errors (npm run test)
is from a uniquely-named feature branch and is up to date with the develop branch.
is descriptively named and links to an issue number, i.e. Fixes #123

Rajnish2105 added 2 commits

December 25, 2024 20:11


          Refactored useWhatPage hook to provide mobileTitle


          Removed accidental test insertion on user/pages for AccountView

e5252b2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet