Show DNSSEC status icon (if applicable) #3185
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: DL6ER <[email protected]>
rdwebdesign
requested changes
Dec 18, 2024
Co-authored-by: RD WebDesign <[email protected]> Signed-off-by: Dominik <[email protected]>
rdwebdesign
previously approved these changes
Dec 18, 2024
rdwebdesign
reviewed
Dec 18, 2024
Signed-off-by: RD WebDesign <[email protected]>
Signed-off-by: RD WebDesign <[email protected]>
yubiuser
reviewed
Dec 21, 2024
| @@ -321,13 +332,13 @@ function formatInfo(data) { | |||
|
|
|||
| // Show DNSSEC status if applicable | |||
| var dnssecInfo = ""; | |||
| if (dnssecClass !== false) { | |||
| if (dnssec.color !== "") { | |||
There was a problem hiding this comment.
Suggested change
| if (dnssec.color !== "") { | |
| if (dnssec.text !== "N/A") { |
While being logical equivalent, it feels strange to base the decision on the color status.
There was a problem hiding this comment.
Actually dnssec.icon and dnssec.color store strings containing CSS classes for the icon shape and icon color.
No color means no icon and text = N/A. No icon means no color and text = N/A. Text=N/A means no icon and no color.
The 3 tests are 100% equivalent:
if (dnssec.color !== "");if (dnssec.icon !== "");if (dnssec.text !== "N/A");
Co-authored-by: yubiuser <[email protected]> Signed-off-by: RD WebDesign <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
This PR adds colored DNSSEC status icons if DNSSEC is enabled inside Pi-hole. It tries to solve the issue that queries which are BOGUS are not immediately visible to the user: Their background color may still be green when they haven't been blocked by Pi-hole.
Example (https://wander.science/projects/dns/dnssec-resolver-test/):
Green closed lock: DNSSEC enabled for this site, verification successful
Orange open lock: DNSSEC not enabled for this site, check not possible
Red triangle: DNSSEC enabled for this side but verification failed
No icon: DNSSEC validation not possible or not enabled for this record, e.g., domain blocked by Pi-hole or DS query for a site having no DS.
Related issue or feature (if applicable): N/A
Pull request in docs with documentation (if applicable): N/A
By submitting this pull request, I confirm the following:
git rebase)Checklist:
developmentalbranch.