Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timepicker helper with added expectation to reduce flakiness #13029

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

mkllnk
Copy link
Member

@mkllnk mkllnk commented Dec 11, 2024

What? Why?

What should we test?

  • Specs only.
  • 100/100 passes locally.
  • 140/140 passed on CI.

Release notes

Changelog Category (reviewers may add a label for the release notes):

  • User facing changes
  • API changes (V0, V1, DFC or Webhook)
  • Technical changes only
  • Feature toggled

The title of the pull request will be included in the release notes.

Dependencies

Documentation updates

@mkllnk mkllnk added the technical changes only These pull requests do not contain user facing changes and are grouped in release notes label Dec 11, 2024
@mkllnk mkllnk self-assigned this Dec 11, 2024
@mkllnk mkllnk force-pushed the flaky-order-cycle-spec branch from 0a6892e to 203ddf7 Compare December 12, 2024 03:24
@mkllnk mkllnk force-pushed the flaky-order-cycle-spec branch 7 times, most recently from 0005079 to 4163b33 Compare December 20, 2024 00:12
@mkllnk mkllnk force-pushed the flaky-order-cycle-spec branch from 4163b33 to c1f8d30 Compare December 20, 2024 00:15
Copy link
Member Author

@mkllnk mkllnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may still fail if CI is having a bad day and is very slow but then we can just increase the sleep time. It's only a fraction of a second and not noticeable by a human at the moment.

@mkllnk mkllnk marked this pull request as ready for review December 20, 2024 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical changes only These pull requests do not contain user facing changes and are grouped in release notes
Projects
Status: Code review 🔎
Development

Successfully merging this pull request may close these issues.

[Flaky] ./spec/system/admin/order_cycles/edit_spec.rb:65
1 participant