-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make overriding scope.name
with logrecord.target
configurable in OTLP Log Exporter
#2102
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main open-telemetry/opentelemetry-specification#2102 +/- ##
=======================================
- Coverage 78.0% 77.9% -0.1%
=======================================
Files 121 121
Lines 20939 20944 +5
=======================================
+ Hits 16335 16336 +1
- Misses 4604 4608 +4 ☔ View full report in Codecov by Sentry. |
scope.name
with logrecord.target
configurable in OTLP Log Exporter
@@ -3,6 +3,10 @@ | |||
## vNext | |||
|
|||
- Fix JSON serialization of `metrics::Exemplar` and `trace::span::Link` [#2069](https://github.com/open-telemetry/opentelemetry-rust/pull/2069) | |||
- [2102](https://github.com/open-telemetry/opentelemetry-rust/pull/2102) | |||
Added feature flag `populate-instrumentation-scope-from-target`, enabled by default. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/open-telemetry/opentelemetry-specification/issues/4154
I am wondering if we should offer this feature flag at all, given the target should be populated as scope always. The appender-name and version can be attributes on the scope. Need to follow the above spec issue before closely.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting. We can instead have a feature flag to populate the appender-name/version as attributes, and keep target
as scope
as we do currently.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that could work, we need to wait for the spec issue to get resolved. For now, we can continue to keep target as scope. what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, we can close this PR and make a decision once the spec issue is resolved
Fixes open-telemetry/opentelemetry-specification#1890
Design discussion issue (if applicable) #
Changes
populate-instrumentation-scope-from-target
in Cargo.toml foropentelemetry-otlp
andopentelemetry-proto
.scope.name
is populated withLogRecord.target
.scope.version
and other fields are empty.scope
is populated from opentelemetry-sdk's "InstrumentatonLibrary".output for:
feature flag disabled
feature flag enabled
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes