feat: parts of the gRPC istrumentation #1303
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michal-kazmierczak
requested review from
fbogsany,
mwear,
robertlaurin,
dazuma,
ericmustin,
arielvalentin,
ahayworth,
plantfansam,
robbkidd,
simi,
kaylareopelle,
xuan-cao-swi and
a team
as code owners
kaylareopelle
requested changes
Dec 17, 2024
There was a problem hiding this comment.
Thank you, @michal-kazmierczak! This looks great! I have a few comments on the files.
Also, I noticed is this PR is from your main branch. We recommend contributors put their work on a branch other than main because the repo's strategy is to squash when we merge, which can cause problems when you update your fork after your main branch is merged.
instrumentation/grpc/lib/opentelemetry/instrumentation/grpc/patches/client_stub.rb
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
This is great, incremental progress. In my opinion, once the branch is updated, this is ready to merge, @michal-kazmierczak.
michal-kazmierczak
force-pushed
the
main
branch
from
d324da0 to
c167be0
Compare
Thank you. I've rebased it now. |
michal-kazmierczak
force-pushed
the
main
branch
2 times, most recently
from
f73d9d9 to
74ced70
Compare
Co-authored-by: Kayla Reopelle <[email protected]>
Co-authored-by: Kayla Reopelle <[email protected]>
…tches/client_stub.rb Co-authored-by: Kayla Reopelle <[email protected]>
Co-authored-by: Kayla Reopelle <[email protected]>
michal-kazmierczak
force-pushed
the
main
branch
from
74ced70 to
4741b3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes parts of the gRPC instrumentation adaptation outlined in: #1261
This PR does not make the gem ready to release.
The primary change is that the instrumentation leverages the use of interceptors (a concept parallel to middlewares).
Also, there is a patch that instruments every stub (client) created after the OpenTelemetry installation. This aligns the instrumentation behavior with other libraries, so end-users do not need to manually add interceptors.
I decided not to include relatively easy changes that would make the diff quite more difficult to follow (i.e. migration to Rubocop). However, this PR also includes the migration from RSpec to minitest and other minor alignments (like installation of Appraisals or unified Rakefile).
It would be great if this PR could be reviewed and merged, allowing me to proceed with the remaining adaptations.