Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable CSRF Protection protect #1209

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Enable CSRF Protection protect #1209

wants to merge 2 commits into from

Conversation

rhythmdesai404
Copy link

  1. Enabled CSRF Protection

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Oct 22, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@rhythmdesai404
Copy link
Author

/easycla

1 similar comment
@rhythmdesai404
Copy link
Author

/easycla

@ericmustin ericmustin changed the base branch from main to add_defensiveness_on_callables October 22, 2024 21:22
@ericmustin ericmustin changed the base branch from add_defensiveness_on_callables to main October 22, 2024 21:22
@ericmustin
Copy link
Contributor

Misclick, sorry about that. Is this PR ready for review?

kaylareopelle
kaylareopelle reviewed Oct 29, 2024
View reviewed changes
instrumentation/action_pack/test/test_helpers/controllers/example_controller.rb
Comment on lines +10 to +11
# Enable CSRF Protection
protect_from_forgery with: :exception
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rhythmdesai404! Since I haven't heard back from you after Eric's comment earlier, I'm assuming this is ready for review.

I'm curious about why we need to turn this on. This is test code, and shouldn't impact the user. Why do we need to enable it here?

@github-actions GitHub Actions
Copy link
Contributor

👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the keep label to hold stale off permanently, or do nothing. If you do nothing this pull request will be closed eventually by the stale bot

@github-actions github-actions bot added the stale Marks an issue/PR stale label Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaylareopelle kaylareopelle kaylareopelle left review comments

@fbogsany fbogsany Awaiting requested review from fbogsany fbogsany is a code owner

@mwear mwear Awaiting requested review from mwear mwear is a code owner

@robertlaurin robertlaurin Awaiting requested review from robertlaurin robertlaurin is a code owner

@dazuma dazuma Awaiting requested review from dazuma dazuma is a code owner

@ericmustin ericmustin Awaiting requested review from ericmustin ericmustin is a code owner

@arielvalentin arielvalentin Awaiting requested review from arielvalentin arielvalentin is a code owner

@ahayworth ahayworth Awaiting requested review from ahayworth ahayworth is a code owner

@plantfansam plantfansam Awaiting requested review from plantfansam plantfansam is a code owner

@robbkidd robbkidd Awaiting requested review from robbkidd robbkidd is a code owner

@simi simi Awaiting requested review from simi simi is a code owner

@xuan-cao-swi xuan-cao-swi Awaiting requested review from xuan-cao-swi xuan-cao-swi is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
stale Marks an issue/PR stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rhythmdesai404 @ericmustin @kaylareopelle