Add automatic RBAC creation for prometheus receiver #3459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Israel Blancas <[email protected]>
swiatekm
reviewed
Dec 2, 2024
swiatekm
reviewed
Dec 4, 2024
Comment on lines
+101
to
+117
| roles, err := Role(params) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| // NOTE: we cannot just unpack the slice, the type checker doesn't coerce the type correctly. | ||
| for _, role := range roles { | ||
| resourceManifests = append(resourceManifests, role) | ||
| } | ||
|
|
||
| roleBindings, err := RoleBinding(params) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| // NOTE: we cannot just unpack the slice, the type checker doesn't coerce the type correctly. | ||
| for _, roleBinding := range roleBindings { | ||
| resourceManifests = append(resourceManifests, roleBinding) | ||
| } |
There was a problem hiding this comment.
I'd prefer to fold these into the manifest factory framework, but the idea of changing all the current functions to return slices doesn't seem appealing. Maybe we can instead do the conversion in manifests.Factory? WDYT @jaronoff97 ?
There was a problem hiding this comment.
Yeah i think modifying the manifest factory to have a method that allows returning a slice makes sense to me. You could accomplish that in a similar way we do the factory without error today.
There was a problem hiding this comment.
I will try. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to tracking Issue(s):
Description of the changes:
RolesandRoleBindingswhen using theprometheusrecieverbased on its configurationRoles,RoleBindings,ClusterRolesorClusterRoleBindingsRoles,RoleBindingswill be created in a different namespace than theOpenTelemetryCollectorinstance,they cannot includeOwnerReferences. This PR avoids them and ensures the resources are removed when neededcontrollers/opentelemetrycollector_controller_test.goto check we are not breaking anything