Enable controller and webhook for TargetAllocator CR #3426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swiatekm
force-pushed
the
feat/enable-ta-crd
branch
from
91a1081 to
9b78ffa
Compare
swiatekm
added
discuss-at-sig
swiatekm
force-pushed
the
feat/enable-ta-crd
branch
from
9b78ffa to
1089b10
Compare
swiatekm
force-pushed
the
feat/enable-ta-crd
branch
from
1089b10 to
ffc8da6
Compare
jaronoff97
reviewed
Dec 2, 2024
jaronoff97
approved these changes
Dec 2, 2024
# Conflicts: # bundle/community/manifests/opentelemetry-operator.clusterserviceversion.yaml # bundle/openshift/manifests/opentelemetry-operator.clusterserviceversion.yaml # Conflicts: # bundle/community/manifests/opentelemetry-operator.clusterserviceversion.yaml # bundle/openshift/manifests/opentelemetry-operator.clusterserviceversion.yaml
Co-authored-by: Jacob Aronoff <[email protected]>
Co-authored-by: Jacob Aronoff <[email protected]>
swiatekm
force-pushed
the
feat/enable-ta-crd
branch
from
e75275a to
4b9a572
Compare
iblancasa
approved these changes
Dec 19, 2024
| @@ -122,6 +123,51 @@ In essence, Prometheus Receiver configs are overridden with a `http_sd_config` d | |||
| Allocator, these are then loadbalanced/sharded to the Collectors. The [Prometheus Receiver](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/receiver/prometheusreceiver/README.md) configs that are overridden | |||
| are what will be distributed with the same name. | |||
|
|
|||
| ## TargetAllocator CRD | |||
There was a problem hiding this comment.
Nit: how about documenting the operator.collector.targetallocatorcr feature flag and explain what is the effect regarding this CRD?
There was a problem hiding this comment.
I'm not sure that's helpful at this point. That flag controls how the collector CR is reconciled, it doesn't have anything to do with the TargetAllocator CR per se. I introduced it specifically so that this PR doesn't change any existing code paths.
|
@IshwarKanse maybe you can provide some ideas about the testing for this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Enable the TargetAllocator CRD. This is really just a bunch of bookkeeping manifest changes, plus some new E2E tests. Note that whether the Collector subresource uses the new CR is still controlled by an alpha feature gate.
I'll clean up and consolidate the tests after this is merged.
Link to tracking Issue(s):
Testing:
Documentation: