Migrate semconv codegen to weaver #5793
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a prototype for discussion and demonstration in next week's Go SiG meeting.
This migrates semconv codegeneration off the (deprecated, soon to be abandoned) semconvgen to weaver.
A few things in this PR:
I couldn't find (easily) the documentation you had previously for generating semconv (which I did find in the collect). This should make it as easy as:
which is how I generated the v1.27.0 code here.
Regarding JINJA formatting, I didn't have a chance to go through whitespace refactoring/fun. For other codegen we run formatting tools as part of the makefile. I've manually run
go fmt
on the generated code, but we would likely want to have that a part of the Makefile to automatically correct Jinja's wierd whitespacing.