Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solid: Some fixes for library and component generation. Fix for playground initialisation. #1164

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ricrachac
Copy link

#1161
Removes an extra libs in the path when updating tsconfig.base.json. The path to the project can be handled by the options.projectDirectory as is.

nx g @nxext/solid:lib hello --directory packages/hello
nx g @nxext/solid:lib libs/world
cat tsconfig.base.json
...
"paths": {
      "@proj/hello": ["packages/hello/src/index.ts"],
      "@proj/world": ["libs/world/src/index.ts"]
    }
...

#1162
TS extension in component export causes issues as we don't have allowImportingTsExtensions. Removing it works as expected.


Misc
Playground error when trying to set up development enviroment. There is no longer a preset empty it seems. nx20 broke a few things in that regard when moving to the new workspace model I think.

NX   Unable to resolve empty:preset.
The "empty" package does not support Nx generators.

@ricrachac ricrachac changed the title Solid: Fixes for library and component generation. #1161 #1162 Fix for playground initialisation Solid: Some fixes for library and component generation. Fix for playground initialisation. Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant