Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: add typescript support to STDIN eval #56359

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

lib: add typescript support to STDIN eval #56359

wants to merge 1 commit into from
+258 −8

Conversation

marco-ippolito
Copy link
Member

@marco-ippolito marco-ippolito commented Dec 25, 2024 •
edited
Loading

After --eval we can add in the same way support for STDIN

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/typescript

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Dec 25, 2024
@marco-ippolito marco-ippolito added semver-minor PRs that contain new features and should be released in the next minor version. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. stdio Issues and PRs related to stdio. strip-types Issues or PRs related to strip-types support labels Dec 25, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 25, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 76.92308% with 6 lines in your changes missing coverage. Please review.

Project coverage is 88.55%. Comparing base (821b0a7) to head (6bf1669).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/main/eval_stdin.js 76.92% 6 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #56359      +/-   ##
==========================================
- Coverage   88.55%   88.55%   -0.01%     
==========================================
  Files         657      657              
  Lines      190655   190675      +20     
  Branches    36584    36592       +8     
==========================================
+ Hits       168838   168844       +6     
- Misses      15001    15015      +14     
  Partials     6816     6816
Files with missing lines Coverage Δ
lib/internal/main/eval_stdin.js 89.47% <76.92%> (-10.53%) ⬇️

... and 34 files with indirect coverage changes

ljharb
ljharb approved these changes Dec 25, 2024
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems solid; i like the combination of flags here.

@marco-ippolito marco-ippolito added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Dec 25, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 25, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64206/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. needs-ci PRs that need a full CI run. semver-minor PRs that contain new features and should be released in the next minor version. stdio Issues and PRs related to stdio. strip-types Issues or PRs related to strip-types support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marco-ippolito @nodejs-github-bot @ljharb