chore: Updated eslint configuration #2851
Open
+1,767
−1,766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsumners-nr
force-pushed
the
neostandard
branch
5 times, most recently
from
8e504e9 to
6c63650
Compare
jsumners-nr
force-pushed
the
neostandard
branch
from
2374e99 to
89ff244
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2851 +/- ##
==========================================
+ Coverage 88.74% 97.22% +8.47%
==========================================
Files 294 295 +1
Lines 46447 46466 +19
==========================================
+ Hits 41221 45175 +3954
+ Misses 5226 1291 -3935
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jsumners-nr
commented
Dec 24, 2024
| @@ -46,7 +46,7 @@ test('should correctly convert bools when false', async () => { | |||
| }) | |||
|
|
|||
| test('should correctly convert integers', async () => { | |||
| const intValue = 9999999999999999 | |||
| const intValue = 999999999999999 | |||
There was a problem hiding this comment.
This one generated an error about the value overflowing. I don't think we were trying to test against an overflowed value, so I just shortened it to fit.
jsumners-nr
force-pushed
the
neostandard
branch
from
89ff244 to
af3771d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolve #2852.
This PR updates the eslint configuration, and plugins, to the latest. I discovered that our shared configuration has not kept up-to-date on the packages that it uses. In particular:
eslintreleased v9 that radically changes (and simplifies) how configuration is written and parsed.eslint-plugin-nodehas been out-of-maintenance for a long time, replaced byeslint-plugin-nThe result was a difficult to update shared configuration package. Now that this PR is ready, I could go back and update the shared package to eslint@9 standards, but I'm not convinced the shared package is worth the maintenance cost. Most of the configuration is specific to the repository. I am quite certain that most of the packages we maintain can get by with the simple
neostandardconfiguration.Having been out-of-date for so long, our code base has developed many "errors" in regard to linting. The sonarjs plugin saw a lot of additions that now trigger errors. So there are many files touched in this PR. I took the approach of overriding the majority of rules for the tests, but using inline comments in the actual library code. I think our tests can be more lenient, and that we can investigate on a case-by-case basis all of the manual overrides.
I think we should wait for the
nextbranch to be merged tomain, at which point I will rebase and update this branch, before we merge. But I'm open to merging this first if the team thinks it will not cause too much strife in keepingnextsynchronized.