Bug 1933585 - Fix TOTP form layout on Account Verification page #2366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dklawren
requested changes
Nov 26, 2024
There was a problem hiding this comment.
The Submit button needs to be below the input field since there is a hidden span next to the input field. When a user enters their mfa code, it does a pre-check via API and displays an error next to the input field if the value is wrong. If the submit button is next to it, would it not slide over?
|
I missed the error message. I’ve modified the markup and style so the message now appears below the input instead of to the right. And I’ve also removed the red background because it was hard to read the text due to low contrast.
|
kyoshino
changed the title
dklawren
changed the title
dklawren
approved these changes
Nov 26, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven’t filed a bug, but I believe this is a fallout from #2334. When you sign in, you’ll probably enter a 6-digit verification code on the Account Verification page. Currently, the Submit button is displayed in full width, which is not an intended layout. This PR fixes it.
(The UI could be better than this, but it’s out of scope 😉)
Before
After