Bug 1932257 - CircleCI configuration cleanups and removal of un-used code in entrypoint.pl #2361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…code in entrypoint.pl
cgsheeh
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than junk up the other pull request for the ETL work with these minor fixes, I am making them here instead. These are changes to the way images are built in CircleCI for running the automated tests as well as some code cleanup to remove unused code and get rid of some warnings in the test output that looks bad.
In order to build the bigquery-emulator container for testing in the ETL pull request, we need to build the images from the docker-compose.test.yml file instead of doing docker builds outside of docker-compose. Instead of
docker build -t bmo . ; docker-compose run bmo.test test_webservices, I dodocker run --build bmo.test test_webservices.For github, I still need to do the
docker-compose buildbefore the test run since for some reason their implementation did not like usingdocker-compose run --build ....I removed some extra functions in entrypoint.pl that are never used by BMO or mozilla-conduit/suite.
The rest of the changes are small fixes to remove warnings and other extra stuff sent to STDOUT that was cluttering up the test logs.