Implement REST datasource driver #5009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JAORMX
commented
Nov 20, 2024
JAORMX
force-pushed
the
datasource-rest-impl
branch
2 times, most recently
from
fe4cde6 to
852f8ba
Compare
JAORMX
force-pushed
the
datasource-rest-impl
branch
from
fbb974b to
f508ead
Compare
| @@ -19,18 +19,26 @@ import ( | |||
| // ValidateSchemaUpdate validates that the new json schema doesn't break | |||
| // profiles using this rule type | |||
| func ValidateSchemaUpdate(oldRuleSchema *structpb.Struct, newRuleSchema *structpb.Struct) error { | |||
There was a problem hiding this comment.
Given the lovely new functions in schemavalidate for conversion, would it make sense to file a cleanup ticket to make these take a pair of jsonschema.Schema?
| for _, desc := range errs { | ||
| problems = append(problems, desc.Error()) | ||
| } | ||
| return fmt.Errorf("invalid json schema: %s", strings.TrimSpace(strings.Join(problems, "\n"))) |
There was a problem hiding this comment.
Do you want to use errors.Join(...error) here (or implement Unwrap() []error upstream) to allow callers to pick apart the errors?
There was a problem hiding this comment.
Good point. Join would make sense.
There was a problem hiding this comment.
I'll leave this as a TODO for another PR since this was moved from existing code.
JAORMX
force-pushed
the
datasource-rest-impl
branch
2 times, most recently
from
329d34d to
fc6d9ae
Compare
|
The security scan failure is a false positive. I don't even know where it's getting that file from 😕 |
|
We're hitting aquasecurity/trivy#7970 |
rdimitrov
reviewed
Nov 21, 2024
rdimitrov
previously approved these changes
Nov 21, 2024
eleftherias
previously approved these changes
Nov 21, 2024
This adds an initial implementation of the REST datasource driver. This allows the user to register multiple REST endpoints to call a data soruce and thus interact with it. This initial implementation left several TODO items which need to be addressed before unleashing the implementation. Signed-off-by: Juan Antonio Osorio <[email protected]>
Signed-off-by: Juan Antonio Osorio <[email protected]>
This is instead handled by the registry. Signed-off-by: Juan Antonio Osorio <[email protected]>
Signed-off-by: Juan Antonio Osorio <[email protected]>
Signed-off-by: Juan Antonio Osorio <[email protected]>
Signed-off-by: Juan Antonio Osorio <[email protected]>
Signed-off-by: Juan Antonio Osorio <[email protected]>
… rest driver Signed-off-by: Juan Antonio Osorio <[email protected]>
JAORMX
force-pushed
the
datasource-rest-impl
branch
from
fc6d9ae to
549f6f4
Compare
rdimitrov
approved these changes
Nov 21, 2024
eleftherias
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds an initial implementation of the REST datasource driver. This
allows the user to register multiple REST endpoints to call a data
soruce and thus interact with it.
This initial implementation left several TODO items which need to be
addressed before unleashing the implementation.
Change Type
Mark the type of change your PR introduces:
Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist: