Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to ACR selection prompting #809

Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open

Conversation

MicroFish91
Copy link
Contributor

@MicroFish91 MicroFish91 commented Dec 19, 2024

Closes #440

Based on feedback from Anthony, let's no longer default the registries if a registry has not already been saved in the workspace settings.

Also, now sort registries by resource group. Resource groups are sorted alphabetically and registries in the same resource group are sorted to the top as recommended.

image

image

If a currently deployed registry exists, don't mark the same resource group registries as recommended, but mark the currently deployed registry instead:

image

Also mention the registry name when prompting for the registry connection method:

image

Base automatically changed from mwf/homely-emerald to main December 20, 2024 23:55
@MicroFish91 MicroFish91 marked this pull request as ready for review December 23, 2024 19:51
@MicroFish91 MicroFish91 requested a review from a team as a code owner December 23, 2024 19:51
@MicroFish91 MicroFish91 marked this pull request as draft December 23, 2024 20:12
@MicroFish91 MicroFish91 changed the title Don't automatically default registries in deployWorkspaceProject implementation Improvements to ACR selection prompting Dec 23, 2024
@MicroFish91 MicroFish91 marked this pull request as ready for review December 24, 2024 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the ACR selection dropdown
1 participant