-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to ACR selection prompting #809
Open
MicroFish91
wants to merge
24
commits into
main
Choose a base branch
from
mwf/fiscal-beige
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…de-azurecontainerapps into mwf/homely-emerald
…ode-azurecontainerapps into mwf/fiscal-beige
…ode-azurecontainerapps into mwf/fiscal-beige
MicroFish91
changed the title
Don't automatically default registries in
Improvements to ACR selection prompting
Dec 23, 2024
deployWorkspaceProject
implementation
MicroFish91
force-pushed
the
mwf/fiscal-beige
branch
from
December 24, 2024 00:32
2de17a8
to
209d1ac
Compare
MicroFish91
force-pushed
the
mwf/fiscal-beige
branch
from
December 24, 2024 19:48
cd8b7a1
to
57661f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #440
Based on feedback from Anthony, let's no longer default the registries if a registry has not already been saved in the workspace settings.
Also, now sort registries by resource group. Resource groups are sorted alphabetically and registries in the same resource group are sorted to the top as
recommended
.If a currently deployed registry exists, don't mark the same resource group registries as recommended, but mark the currently deployed registry instead:
Also mention the registry name when prompting for the registry connection method: