Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: improved text_search folder testing #9984

Merged
merged 8 commits into from
Dec 19, 2024

Conversation

eavanvalkenburg
Copy link
Member

@eavanvalkenburg eavanvalkenburg commented Dec 16, 2024

Motivation and Context

added unit tests to up the test coverage across the data folder
Also redoes exceptions for everything vector.

This does introduce some breaking changes on the exceptions returned by the different methods for vector stores, they are still marked experimental and this will go a long way in moving towards release.

Closes #9485

Description

Contribution Checklist

@eavanvalkenburg eavanvalkenburg requested a review from a team as a code owner December 16, 2024 11:44
@markwallace-microsoft markwallace-microsoft added the python Pull requests for the Python Semantic Kernel label Dec 16, 2024
@github-actions github-actions bot changed the title improved text_search folder testing Python: improved text_search folder testing Dec 16, 2024
@markwallace-microsoft
Copy link
Member

markwallace-microsoft commented Dec 16, 2024

Python Test Coverage

Python Test Coverage Report •
FileStmtsMissCoverMissing
semantic_kernel/connectors/memory/azure_ai_search
   azure_ai_search_collection.py1373674%174, 176, 249–290, 300–310, 314, 318, 323–326
   azure_ai_search_store.py42295%130–131
semantic_kernel/connectors/memory/azure_cosmos_db
   azure_cosmos_db_no_sql_base.py50982%93, 96–97, 105, 115–119
   azure_cosmos_db_no_sql_collection.py1565267%98–99, 140–147, 158–172, 178–184, 190–194, 217–228, 232, 236, 260, 288–289, 293–298
   azure_cosmos_db_no_sql_store.py33682%91–96
   utils.py55787%43, 66, 91, 186, 200–203
semantic_kernel/connectors/memory/redis
   redis_collection.py2414780%174, 179–180, 191–201, 209–229, 232–239, 254–259, 263, 339, 376–383, 461, 483–490
   redis_store.py42295%108–109
   utils.py713255%153–154, 172, 174, 181–196, 203–233
semantic_kernel/connectors/memory/weaviate
   utils.py802272%92–97, 194, 243, 262, 269–272, 281–292
   weaviate_collection.py1775967%173–176, 180–186, 190–191, 202–219, 226–233, 242–262, 271–287, 291, 294–298, 342, 346–353, 368, 387, 403, 412–413, 419, 424
   weaviate_store.py591771%110–118, 122–127, 132–137, 142–143
semantic_kernel/data/vector_search
   vector_search.py33294%124–125
   vector_text_search.py20385%56–59
   vectorizable_text_search.py19384%61–64
   vectorized_search.py19384%56–59
TOTAL16749176989% 

Python Unit Test Overview

Tests Skipped Failures Errors Time
2995 4 💤 0 ❌ 0 🔥 1m 12s ⏱️

@eavanvalkenburg eavanvalkenburg added this pull request to the merge queue Dec 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 18, 2024
@eavanvalkenburg eavanvalkenburg added this pull request to the merge queue Dec 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 18, 2024
@eavanvalkenburg eavanvalkenburg added this pull request to the merge queue Dec 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 19, 2024
@eavanvalkenburg eavanvalkenburg added this pull request to the merge queue Dec 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 19, 2024
@eavanvalkenburg eavanvalkenburg added this pull request to the merge queue Dec 19, 2024
Merged via the queue into microsoft:main with commit 3bab848 Dec 19, 2024
25 checks passed
@eavanvalkenburg eavanvalkenburg deleted the improve_data_tests branch December 19, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
memory python Pull requests for the Python Semantic Kernel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python: Vector store & collection specific exception types
4 participants