fix(epoll): buffer overflow when GSO off #4717
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nibanks
added
OS: Ubuntu
external
qzhuyan
added a commit
to qzhuyan/quic
that referenced
this pull request
Dec 19, 2024
- buffer overflow when tracing - buffer overflow when GSO off, Linux epoll, large payload microsoft/msquic#4717
qzhuyan
added a commit
to qzhuyan/quic
that referenced
this pull request
Dec 19, 2024
- buffer overflow when tracing - buffer overflow when GSO off, Linux epoll, large payload microsoft/msquic#4717
|
More info of ASAN check (without the fix) here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix buffer overflow that SendData buffer size could not be checked correctly in
CxPlatSendDataFinalizeSendBufferwhenSendData->SegmentSizeis 0.This issue was found in a env where GSO is off, mtu size 1400 and sending large payload (size: 780038) + Linux epoll.
It is hard to reproduce in other env.
this is a quick fix and hurt performance, I think for long term the
CxPlatSendDataFinalizeSendBuffershould be aware of the allocating buffer size.Testing
_
Documentation
_