Full y axis labels in Heatmap chart #33509
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report✅ No changes found |
fabricteam
reviewed
Dec 23, 2024
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵🏾♀️ visual regressions to review in the fluentuiv8 Visual Regression Report
Callout 6 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Callout.Left center.chromium.png | 2616 | Changed |
| Callout.Top center.chromium.png | 2178 | Changed |
| Callout.Top left edge.chromium.png | 2307 | Changed |
| Callout.No callout width specified.chromium.png | 2319 | Changed |
| Callout.Bottom auto edge.chromium.png | 2309 | Changed |
| Callout.No beak.chromium.png | 2306 | Changed |
Keytip 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Keytip.Offset.chromium.png | 121 | Changed |
react-charting-HeatMapChart 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| react-charting-HeatMapChart.Basic.chromium.png | 307 | Changed |
| react-charting-HeatMapChart.Basic Dark Mode.chromium.png | 320 | Changed |
react-charting-LineChart 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| react-charting-LineChart.Events.chromium.png | 2 | Changed |
| react-charting-LineChart.Gaps.chromium.png | 1 | Changed |
react-charting-VerticalBarChart 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| react-charting-VerticalBarChart.Basic - Secondary Y Axis.chromium.png | 4 | Changed |
|
Pull request demo site: URL |
srmukher
reviewed
Dec 23, 2024
packages/charts/react-charting/src/components/CommonComponents/CartesianChart.base.tsx
Outdated
Show resolved
Hide resolved
srmukher
reviewed
Dec 23, 2024
packages/charts/react-charting/src/components/CommonComponents/CartesianChart.base.tsx
Outdated
Show resolved
Hide resolved
AtishayMsft
reviewed
Dec 23, 2024
| /** | ||
| *@default false | ||
| *Used for showing complete y axis lables */ | ||
| showYAxisLables?: boolean; |
There was a problem hiding this comment.
Build is failing without this. Because, in plotlyadapter file, we don't have reference to ICartesianchartProps. This prop is defined in HBCWithAxis also, so I think it is needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Behavior
Full Y Axis labels feature in Heatmap chart.
Related Issue(s)