chore: upgrade typescript to 5.5.2 #33498
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabricteam
reviewed
Dec 20, 2024
| @@ -69,8 +69,8 @@ | |||
| "@griffel/webpack-loader": "2.2.10", | |||
There was a problem hiding this comment.
🕵🏾♀️ visual regressions to review in the fluentuiv9 Visual Regression Report
Avatar Converged 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Avatar Converged.badgeMask.chromium.png | 8 | Changed |
| Avatar Converged.Badge Mask RTL.chromium.png | 3 | Changed |
Drawer 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Drawer.Full Overlay Dark Mode.chromium.png | 2825 | Changed |
| Drawer.Full Overlay RTL.chromium.png | 3278 | Changed |
🕵 FluentUIV0 No visual regressions between this PR and main |
mainframev
commented
Dec 20, 2024
| @@ -85,7 +91,9 @@ export function classNamesFunction<TStyleProps extends {}, TStyleSet extends ISt | |||
| typeof styleFunctionOrObject === 'function' && | |||
| (styleFunctionOrObject as StyleFunction<TStyleProps, TStyleSet>).__noStyleOverride__ | |||
| ) { | |||
| return styleFunctionOrObject(styleProps) as IProcessedStyleSet<TStyleSet>; | |||
| return (styleFunctionOrObject as IStyleFunction<TStyleProps, TStyleSet>)( | |||
There was a problem hiding this comment.
had to add additional casting, throwing after upgrade with this TS2349:
| state.components?.[slotName] === undefined || typeof state.components[slotName] === 'string' | ||
| ? asProp || state.components?.[slotName] || 'div' | ||
| : state.components[slotName] | ||
| ) as React.ElementType<R[K]>; | ||
| : state.components[slotName]; |
There was a problem hiding this comment.
after upgrade throws TS2590: Expression produces a union type that is too complex to represent
mainframev
force-pushed
the
chore/ts-update-5-5
branch
2 times, most recently
from
29cadea to
ea576b0
Compare
mainframev
commented
Dec 20, 2024
packages/codemods/package.json
Outdated
| @@ -31,6 +31,7 @@ | |||
| "tslib": "^2.1.0", | |||
| "react": "17.0.2", | |||
| "ts-morph": "^10.0.1", | |||
| "typescript": "5.3.3", | |||
There was a problem hiding this comment.
had to lock ts to 5.3.3 for this package, as ts-morph has issue with 5.4: dsherret/ts-morph#1513. Fixed in v22, current is 10 😢
mainframev
force-pushed
the
chore/ts-update-5-5
branch
from
ea576b0 to
3ee9cbd
Compare
fabricteam
reviewed
Dec 20, 2024
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵🏾♀️ visual regressions to review in the fluentuiv8 Visual Regression Report
Callout 5 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Callout.Left top edge.chromium.png | 1949 | Changed |
| Callout.Bottom auto edge.chromium.png | 2309 | Changed |
| Callout.Bottom Right Edge RTL.chromium.png | 1593 | Changed |
| Callout.Bottom Left Edge RTL.chromium.png | 2178 | Changed |
| Callout.No beak.chromium.png | 2306 | Changed |
|
Pull request demo site: URL |
mainframev
force-pushed
the
chore/ts-update-5-5
branch
from
3ee9cbd to
83e4110
Compare
📊 Bundle size report
Unchanged fixtures
|
mainframev
force-pushed
the
chore/ts-update-5-5
branch
from
83e4110 to
0e865c5
Compare
chore(utilities): update api.md chore(react-utilities): update api.md chore(style-utilities): update api.md
mainframev
force-pushed
the
chore/ts-update-5-5
branch
from
0e865c5 to
0a3b8eb
Compare
fabricteam
reviewed
Dec 23, 2024
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵🏾♀️ visual regressions to review in the fluentui-web-components-v3 Visual Regression Report
Avatar 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Avatar.Image.chromium.png | 248 | Changed |
mainframev
force-pushed
the
chore/ts-update-5-5
branch
2 times, most recently
from
dbda8d7 to
9f52366
Compare
mainframev
force-pushed
the
chore/ts-update-5-5
branch
from
9f52366 to
415da9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@importJSDoc tags.Release notes
https://www.typescriptlang.org/docs/handbook/release-notes/typescript-5-4.html
https://www.typescriptlang.org/docs/handbook/release-notes/typescript-5-5.html
Related to configDir template var: the initial assumption, that it will help to get rid of explicit typeRoots for
tsconfig.cy.jsonfiles appeared to be wrong. It works for scenarios, where derived config (packages//tsconfig.json) has to have paths related to final directory, before it was needed to re-specify the config property for derived config.Previous Behavior
5.3.3
New Behavior
5.5.2
Related Issue(s)
(nx run-many -t build type-check --skip-nx-cache)