[Area Chart] Support legend multi selection #33475
Open
+90
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AtishayMsft
reviewed
Dec 17, 2024
| // Show the circle if no legends are selected or if the point's legend is in the selected legends | ||
| if (selectedLegends.length > 0 && !selectedLegends.includes(legend)) { | ||
| return 0; | ||
| } |
There was a problem hiding this comment.
this is missing out on legend hovered condition.
…sers/srmukher/AreaMultiSel
📊 Bundle size report✅ No changes found |
|
Pull request demo site: URL |
fabricteam
reviewed
Dec 19, 2024
| @@ -194,6 +194,7 @@ export interface IAccessibilityProps { | |||
|
|
|||
There was a problem hiding this comment.
🕵🏾♀️ visual regressions to review in the fluentuiv8 Visual Regression Report
Callout 4 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Callout.Left center.chromium.png | 2616 | Changed |
| Callout.Bottom Right Edge RTL.chromium.png | 1593 | Changed |
| Callout.Top center.chromium.png | 2178 | Changed |
| Callout.Bottom auto edge.chromium.png | 2309 | Changed |
react-charting-LineChart 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| react-charting-LineChart.Gaps.chromium.png | 1 | Changed |
AtishayMsft
reviewed
Dec 23, 2024
| @@ -194,6 +194,7 @@ export interface IAccessibilityProps { | |||
|
|
|||
| // @public | |||
| export interface IAreaChartProps extends ICartesianChartProps { | |||
| canSelectMultipleLegends?: boolean; | |||
AtishayMsft
reviewed
Dec 23, 2024
| @@ -621,10 +612,16 @@ export class AreaChartBase extends React.Component<IAreaChartProps, IAreaChartSt | |||
| enabledWrapLines={this.props.enabledLegendsWrapLines} | |||
| focusZonePropsInHoverCard={this.props.focusZonePropsForLegendsInHoverCard} | |||
| {...this.props.legendProps} | |||
| canSelectMultipleLegends={this.props.canSelectMultipleLegends} | |||
AtishayMsft
reviewed
Dec 23, 2024
| @@ -621,10 +612,16 @@ export class AreaChartBase extends React.Component<IAreaChartProps, IAreaChartSt | |||
| enabledWrapLines={this.props.enabledLegendsWrapLines} | |||
| focusZonePropsInHoverCard={this.props.focusZonePropsForLegendsInHoverCard} | |||
| {...this.props.legendProps} | |||
| canSelectMultipleLegends={this.props.canSelectMultipleLegends} | |||
| onChange={this._onLegendChange} | |||
AtishayMsft
reviewed
Dec 23, 2024
| const filteredValues = | ||
| this.state.selectedLegends.length > 0 | ||
| ? found.values.filter((value: { legend: string }) => this.state.selectedLegends.includes(value.legend)) | ||
| : found.values; |
There was a problem hiding this comment.
move logic to function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support legend multi selection for area chart